<html>
<head><meta charset="utf-8"><title>FCP for toolstate change · t-compiler/wg-rustc-dev-guide · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/index.html">t-compiler/wg-rustc-dev-guide</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html">FCP for toolstate change</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="177158515"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177158515" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177158515">(Oct 02 2019 at 15:02)</a>:</h4>
<p>Just to let everyone know about <a href="https://github.com/rust-lang/rust/issues/65000" target="_blank" title="https://github.com/rust-lang/rust/issues/65000">https://github.com/rust-lang/rust/issues/65000</a>, in particular <span class="user-mention" data-user-id="198054">@mark-i-m</span>, <span class="user-mention" data-user-id="218647">@Amanjeev Sethi</span> and myself are the ones included there</p>



<a name="177158552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177158552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177158552">(Oct 02 2019 at 15:03)</a>:</h4>
<p>to be honest, I'm not 100% sure what am I agreeing to if I click the box</p>



<a name="177158638"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177158638" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177158638">(Oct 02 2019 at 15:03)</a>:</h4>
<p>I guess you agree to be pinged when the PR is reviewed?</p>



<a name="177159214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177159214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> amanjeev <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177159214">(Oct 02 2019 at 15:08)</a>:</h4>
<p>I was going to ask that myself. Glad you raised it</p>



<a name="177159245"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177159245" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177159245">(Oct 02 2019 at 15:09)</a>:</h4>
<p><span class="user-mention" data-user-id="198054">@mark-i-m</span> is the one that is more aware/knowledgeable of these things :)</p>



<a name="177159404"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177159404" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177159404">(Oct 02 2019 at 15:10)</a>:</h4>
<p>IMO: As far as rustc-guide is concerned, I would agree</p>



<a name="177159493"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177159493" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> amanjeev <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177159493">(Oct 02 2019 at 15:11)</a>:</h4>
<p>Sorry what is FCP/</p>



<a name="177160151"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177160151" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177160151">(Oct 02 2019 at 15:17)</a>:</h4>
<p>I may be mistaken, but the topic is whether we agree or not <a href="https://github.com/rust-lang/rust/pull/64977" target="_blank" title="https://github.com/rust-lang/rust/pull/64977">https://github.com/rust-lang/rust/pull/64977</a> ?</p>



<a name="177160738"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177160738" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177160738">(Oct 02 2019 at 15:23)</a>:</h4>
<blockquote>
<p>Sorry what is FCP/</p>
</blockquote>
<p>Final Comment Period</p>



<a name="177160800"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177160800" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177160800">(Oct 02 2019 at 15:23)</a>:</h4>
<blockquote>
<p>I may be mistaken, but the topic is whether we agree or not <a href="https://github.com/rust-lang/rust/pull/64977" target="_blank" title="https://github.com/rust-lang/rust/pull/64977">https://github.com/rust-lang/rust/pull/64977</a> ?</p>
</blockquote>
<p>I guess it's if we agree and if we would like to be in the review process</p>



<a name="177160808"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177160808" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177160808">(Oct 02 2019 at 15:23)</a>:</h4>
<p>but honestly unsure</p>



<a name="177160932"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177160932" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177160932">(Oct 02 2019 at 15:24)</a>:</h4>
<blockquote>
<blockquote>
<p>Sorry what is FCP/</p>
</blockquote>
<p>Final Comment Period</p>
</blockquote>
<p><a href="https://github.com/rust-lang/rustc-guide/blob/master/src/implementing_new_features.md" target="_blank" title="https://github.com/rust-lang/rustc-guide/blob/master/src/implementing_new_features.md">https://github.com/rust-lang/rustc-guide/blob/master/src/implementing_new_features.md</a></p>



<a name="177160998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177160998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> amanjeev <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177160998">(Oct 02 2019 at 15:25)</a>:</h4>
<p>oh thank you! I have so many acronyms at my new job and am drowning</p>



<a name="177162282"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177162282" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> amanjeev <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177162282">(Oct 02 2019 at 15:38)</a>:</h4>
<p>So we wait for <span class="user-mention" data-user-id="198054">@mark-i-m</span> to enlighten us? <span aria-label="smiley" class="emoji emoji-1f603" role="img" title="smiley">:smiley:</span></p>



<a name="177163046"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177163046" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177163046">(Oct 02 2019 at 15:47)</a>:</h4>
<p>I'd just tick by myself, but still I'd wait for <span class="user-mention" data-user-id="198054">@mark-i-m</span> to see what they think about it</p>



<a name="177163419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177163419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> amanjeev <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177163419">(Oct 02 2019 at 15:51)</a>:</h4>
<p>I do not have permission to edit the comment. Should I ask you to do it ?</p>



<a name="177164156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177164156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177164156">(Oct 02 2019 at 15:59)</a>:</h4>
<p>do you want me to tick on your name?</p>



<a name="177164939"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177164939" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> amanjeev <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177164939">(Oct 02 2019 at 16:08)</a>:</h4>
<p>Sure! I am still not sure what impact does this have for us but ok</p>



<a name="177172285"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177172285" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177172285">(Oct 02 2019 at 17:25)</a>:</h4>
<p>This is agreeing to:</p>
<p>if we proceed with this change, submodule changes will no longer be gated when landing into master (modulo beta week). The theory behind this is that rollups can always include all toolstate-gated submodule changes, whereas currently it's pretty much impossible.</p>
<p>I can answer questions if you have them.</p>



<a name="177172400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177172400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177172400">(Oct 02 2019 at 17:26)</a>:</h4>
<p>Basically it means when you or someone else updates the rustc-guide(?) the PR updating the submodule in rust-lang/rust will land faster, but possibly won't fix test failures and such if there are test failures</p>



<a name="177182582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177182582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177182582">(Oct 02 2019 at 19:15)</a>:</h4>
<p>I might be mistaken, but i think this is already the case for the guide.</p>



<a name="177182642"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177182642" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177182642">(Oct 02 2019 at 19:16)</a>:</h4>
<p>Personally, I agree to the change (cc <span class="user-mention" data-user-id="116122">@simulacrum</span> because I can't tick my box)</p>



<a name="177182773"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177182773" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177182773">(Oct 02 2019 at 19:17)</a>:</h4>
<p>That's possible, yes, I think we have several tools that are like that, though I think today it's a global thing (affects beta too). Will tick your box soon</p>



<a name="177184082"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP%20for%20toolstate%20change/near/177184082" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/FCP.20for.20toolstate.20change.html#177184082">(Oct 02 2019 at 19:33)</a>:</h4>
<p>ticked</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>